Fixes #37642 - Drop compatibility with smart_proxy_openscap < 0.6.1 #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures seem related to the changes. |
|
Yes, I missed something in the tests. Updated. |
|
hello, I ran oscap-related tests from robottelo against stream with this PR's packit, the results matched with what we have seen with the latest stream snap |
pondrejk
approved these changes
Jul 10, 2024
If this was still needed, we could use capabilities and easily check this statically but version 0.6.1 was released in 2017 so by now it's safe to assume it's new enough. Dropping the old code makes it more reliable and we have less code to maintain.
ekohl
changed the title
|
Updated the commit message to refer to a Redmine issue. No content change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this was still needed, we could use capabilities and easily check this statically but version 0.6.1 was released in 2017 so by now it's safe to assume it's new enough.
Dropping the old code makes it more reliable and we have less code to maintain.
I must admit I've only grepped through the source and am not that familiar with the codebase, so it realistic that I missed something.