Fixes #37396 - Fix autocomplete for ArfReports #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code expected that a host would have up to one lifecycle environment, which doesn't hold anymore on recent versions of katello. This tripped up scoped_search which couldn't find the right association to search on.
|
checked on patched stream from the functional side, before:
after:
|
pondrejk
approved these changes
Apr 30, 2024
|
Thanks, @adamruzicka and @pondrejk ! Although, it fixes the initial issues, I guess we still might have problem that search by lifecycle env won't work: This can be also problem on my machine, but if you can reproduce it, do we want to fix that as part of this PR or should we deal with that later? |
We have to elaborate a bit on the associations to make scoped_search be able to put the search together through the entire chain of the associations.
ofedoren
approved these changes
May 15, 2024
Comment on lines
+112
to
+115
| has_one :content_facet, :through => :host | ||
| has_many :content_view_environment_content_facets, through: :content_facet, class_name: 'Katello::ContentViewEnvironmentContentFacet' | ||
| has_many :content_view_environments, through: :content_view_environment_content_facets | ||
| has_many :content_views, through: :content_view_environments |
There was a problem hiding this comment.
I thought you'll fix that in the way it's done for the other searches through ext_method, but that's seems fine as well :)
ofedoren
pushed a commit
that referenced
this pull request
May 15, 2024
* Fixes #37396 - Fix autocomplete for ArfReports The code expected that a host would have up to one lifecycle environment, which doesn't hold anymore on recent versions of katello. This tripped up scoped_search which couldn't find the right association to search on. * Fixes #37396 - Fix search on lifecycle_environments We have to elaborate a bit on the associations to make scoped_search be able to put the search together through the entire chain of the associations. (cherry picked from commit 868769f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code expected that a host would have up to one lifecycle environment, which doesn't hold anymore on recent versions of katello. This tripped up scoped_search which couldn't find the right association to search on.