Fixes #37511 - Drop all OVAL related things

.rubocop_todo.yml

@@ -1,16 +1,15 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-09-03 09:57:21 UTC using RuboCop version 1.19.1.
+# on 2024-03-13 11:48:33 UTC using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 3
+# Offense count: 2
 # Configuration parameters: AllowSafeAssignment.
 Lint/AssignmentInCondition:
   Exclude:
-    - 'app/controllers/concerns/foreman/controller/parameters/oval_content.rb'
     - 'app/controllers/scap_contents_controller.rb'
     - 'app/controllers/tailoring_files_controller.rb'
 
@@ -45,23 +44,21 @@ Lint/SendWithMixinArgument:
   Exclude:
     - 'lib/foreman_openscap/engine.rb'
 
-# Offense count: 17
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'app/services/foreman_openscap/openscap_proxy_version_check.rb'
-    - 'app/services/foreman_openscap/oval/setup.rb'
     - 'app/views/api/v2/compliance/common/_loc.json.rabl'
     - 'app/views/api/v2/compliance/common/_org.json.rabl'
-    - 'app/views/api/v2/compliance/oval_policies/main.json.rabl'
     - 'app/views/api/v2/compliance/policies/children.json.rabl'
     - 'app/views/api/v2/compliance/scap_content_profiles/main.json.rabl'
     - 'app/views/api/v2/compliance/scap_contents/show.json.rabl'
     - 'app/views/api/v2/compliance/tailoring_files/show.json.rabl'
     - 'lib/foreman_openscap/engine.rb'
 
-# Offense count: 42
+# Offense count: 34
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
@@ -72,10 +69,7 @@ Lint/UnusedMethodArgument:
     - 'app/models/concerns/foreman_openscap/compliance_status_scoped_search.rb'
     - 'app/models/concerns/foreman_openscap/host_extensions.rb'
     - 'app/models/foreman_openscap/compliance_status.rb'
-    - 'app/models/foreman_openscap/oval_status.rb'
     - 'app/services/foreman_openscap/lookup_key_overrides_common.rb'
-    - 'app/services/foreman_openscap/oval/configure.rb'
-    - 'app/services/foreman_openscap/oval/setup.rb'
 
 # Offense count: 6
 Lint/UselessAssignment:
@@ -98,33 +92,22 @@ Performance/RegexpMatch:
     - 'app/models/concerns/foreman_openscap/openscap_proxy_core_extensions.rb'
     - 'app/services/foreman_openscap/hostgroup_overrider_common.rb'
 
-# Offense count: 13
-# Cop supports --auto-correct.
-Rails/ContentTag:
-  Exclude:
-    - 'app/helpers/arf_reports_helper.rb'
-    - 'app/helpers/policies_helper.rb'
-    - 'app/helpers/policy_dashboard_helper.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforceForPrefixed.
 Rails/Delegate:
   Exclude:
     - 'app/models/foreman_openscap/asset.rb'
 
-# Offense count: 18
+# Offense count: 17
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/HasManyOrHasOneDependent:
   Exclude:
-    - 'app/models/concerns/foreman_openscap/oval_facet_host_extensions.rb'
+    - 'app/models/concerns/foreman_openscap/host_extensions.rb'
     - 'app/models/concerns/foreman_openscap/smart_proxy_extensions.rb'
     - 'app/models/foreman_openscap/arf_report.rb'
     - 'app/models/foreman_openscap/asset.rb'
-    - 'app/models/foreman_openscap/cve.rb'
-    - 'app/models/foreman_openscap/oval_content.rb'
-    - 'app/models/foreman_openscap/oval_policy.rb'
     - 'app/models/foreman_openscap/policy.rb'
     - 'app/models/foreman_openscap/scap_content.rb'
     - 'app/models/foreman_openscap/scap_content_profile.rb'
@@ -138,13 +121,12 @@ Rails/HttpStatus:
   Exclude:
     - 'app/controllers/api/v2/compliance/policies_controller.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/InverseOf:
   Exclude:
     - 'app/models/concerns/foreman_openscap/host_extensions.rb'
-    - 'app/models/concerns/foreman_openscap/oval_facet_host_extensions.rb'
     - 'app/models/concerns/foreman_openscap/smart_proxy_extensions.rb'
     - 'app/models/foreman_openscap/arf_report.rb'
 
@@ -157,6 +139,7 @@ Rails/LexicallyScopedActionFilter:
     - 'app/controllers/scap_contents_controller.rb'
 
 # Offense count: 2
+# Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
 Rails/Output:
@@ -178,6 +161,3 @@ Rails/ReadWriteAttribute:
 Rails/TimeZone:
   Exclude:
     - 'app/models/foreman_openscap/arf_report.rb'
-
-Rails/HasManyOrHasOneDependent:
-  Enabled: false

README.md

@@ -19,7 +19,6 @@ of Foreman based infrastructure.
   + Waive known issues (one-time waivers, re-occurring, waivers)
   + Ad-hoc audit of given machine
   + Support for PreupgradeAssistant evaluation
-  + Vulnerability Assessment (processing OVAL CVE streams)
   + E-mail notifications
 
 ## Usage