Fixes #37466 - Support Zeitwerk loader #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
force-pushed
the
feat-37466-support-zeitwerk
branch
from
a14b6d4
to
4bdfeb8
Compare
ofedoren
changed the title
ofedoren
force-pushed
the
feat-37466-support-zeitwerk
branch
from
4bdfeb8
to
026369b
Compare
ofedoren
force-pushed
the
feat-37466-support-zeitwerk
branch
from
026369b
to
79bc4de
Compare
|
Test failure is a GH timeout. Seeding worked with Ruby 2.7 and all the other tests pass so IMHO we can ignore it. |
ofedoren
force-pushed
the
feat-37466-support-zeitwerk
branch
2 times, most recently
from
c85149e
to
734de93
Compare
ofedoren
force-pushed
the
feat-37466-support-zeitwerk
branch
from
734de93
to
c8534b1
Compare
|
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
ekohl
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP