Move to inline settings validations #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This makes it clearer how the setting is exactly defined. As a bonus, this syntax is compatible with both Ruby 2 and 3.
ekohl
force-pushed
the
inline-settings-validations
branch
from
8b5b6b9
to
5e64c82
Compare
|
I included part of #622 because otherwise many tests failed. |
|
[test foreman_discovery] |
ekohl
force-pushed
the
inline-settings-validations
branch
from
a9bd07b
to
215d574
Compare
|
I dropped the temporary commit and should now be good to go. |
nofaralfasi
approved these changes
Feb 15, 2024
|
Thanks @ekohl |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clearer how the setting is exactly defined. As a bonus, this syntax is compatible with both Ruby 2 and 3. At least, that's what I hope the tests will confirm for me.