Rubocop #607
Merged
Rubocop #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stejskalleos
force-pushed
the
ls/rubocop
branch
from
2f7df4b
to
74434f2
Compare
|
@nofaralfasi review please |
ekohl
reviewed
Sep 20, 2023
There was a problem hiding this comment.
I've asked @archanaserver to look at updating theforeman-rubocop to a more recent version. Enabling this in CI is a good first step.
stejskalleos
force-pushed
the
ls/rubocop
branch
from
ef50ee2
to
c5e1e51
Compare
|
Ruby tests are changing probably due to some changes in the |
ekohl
approved these changes
Oct 5, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.