Fix gettext:store_action_names #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Object.const_source_location stopped being reliable since the zeitwerk changes landed. Each action is expected to define at least one of the three methods, so a source location of a method should be a reliable indicator of where the action comes from.
adamruzicka
force-pushed
the
action-gettext
branch
from
91c2232
to
a29aa8d
Compare
ianballou
reviewed
Oct 24, 2024
ekohl
approved these changes
Oct 24, 2024
ofedoren
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks, @adamruzicka, @ianballou and @ekohl, let's get this in then :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Object.const_source_location stopped being reliable since the zeitwerk changes landed. Each action is expected to define at least one of the three methods, so a source location of a method should be a reliable indicator of where the action comes from.
An alternative to #759