Fixes #37452 - Support Zeitwerk loader #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofedoren
commented
May 14, 2024
This was referenced May 15, 2024
ekohl
reviewed
May 28, 2024
We could, but it will imply that we would need to either make custom inflector for the plugin, which won't affect core and other plugins or make it acronym in the core, so we have consistency. The later will bring even more changes across the plugins :/ |
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
from
4b6401a
to
2b4b7e7
Compare
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
from
2b4b7e7
to
dd3cb93
Compare
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
from
dd3cb93
to
6f742d6
Compare
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
from
6f742d6
to
35bfeab
Compare
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
2 times, most recently
from
e1d2cbc
to
35fa271
Compare
|
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
ofedoren
force-pushed
the
feat-37452-support-zeitwerk
branch
from
35fa271
to
c0e6bc4
Compare
adamruzicka
approved these changes
Sep 10, 2024
|
Thank you @ofedoren ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP