Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Copr projects #9290

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Manage Copr projects #9290

merged 1 commit into from
Aug 11, 2023

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 11, 2023

As we consider a move towards Copr, this aims to manage the projects and configuration directly alongside our packages rather than in tool_belt as we did with Koji. This should allow better cohesion when branching between packages and where they are built.

This will require -- theforeman/obal#345

package_manifest.yaml Outdated Show resolved Hide resolved
package_manifest.yaml Outdated Show resolved Hide resolved
package_manifest.yaml Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the copr-projects branch 2 times, most recently from 2ce9cb6 to e831f7c Compare May 2, 2023 18:10
@@ -29,9 +29,31 @@ all:
dist: '.el8'
macros:
foremandist: "{{ foremandist }}"
copr_project_user: "theforeman"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no such user (but there is a @theforeman group), which makes me wonder if this variable is really more a copr_project_namespace?

@evgeni
Copy link
Member

evgeni commented May 6, 2023

Conceptual question: the foreman, plugins and katello settings for external repos and modules are rather identical (foreman has puppet, but that also doesn't hurt the others), should we try to unify those? Either via a variable or an yaml anchor? Both would allow override if need be, but prevent unsynchronized changes by default

@ehelms
Copy link
Member Author

ehelms commented May 16, 2023

This can be reviewed now in context with theforeman/obal#344.

I am additionally looking into spinning up a secondary Jenkins job that will run Copr builds in parallel to our Koji builds to allow us some period of testing and building parity.

@ehelms
Copy link
Member Author

ehelms commented Jun 1, 2023

[test rpm-copr]

2 similar comments
@ehelms
Copy link
Member Author

ehelms commented Jun 1, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jun 1, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

9 similar comments
@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 7, 2023

[test rpm-copr]

@ehelms ehelms force-pushed the copr-projects branch 5 times, most recently from 1aff41b to 622d33d Compare July 14, 2023 02:17
@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

[test rpm-copr]

3 similar comments
@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

[test rpm-copr]

@ehelms ehelms force-pushed the copr-projects branch 2 times, most recently from e257e59 to 8aad743 Compare July 14, 2023 03:25
@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

[test rpm-copr]

@ehelms
Copy link
Member Author

ehelms commented Jul 14, 2023

The Obal code that supports this work has been merged. This change does not shift us over to Copr directly. This change provides the needed structure to allow us to begin doing Copr scratch builds on every PR and will be conditionally handled by the new rpm-copr job (theforeman/jenkins-jobs#343). My plan is:

  1. Enable scratch builds to test out the Copr workflow
  2. Follow up with a release job for Copr to start also building in parallel to Copr in a non-blocking way

@ehelms
Copy link
Member Author

ehelms commented Aug 1, 2023

I have added comps file support here which requires theforeman/obal#358

package_manifest.yaml Outdated Show resolved Hide resolved
- 'python39:3.9'
- 'nodejs:12'
external_repos:
- https://download.copr.fedorainfracloud.org/results/@theforeman/foreman-nightly-staging/rhel-8-x86_64/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copr can refer to other coprs using copr://user/project syntax -- no idea if that's better or worse, but wanted to point it out :)

@evgeni
Copy link
Member

evgeni commented Aug 11, 2023

Conceptual question: the foreman, plugins and katello settings for external repos and modules are rather identical (foreman has puppet, but that also doesn't hurt the others), should we try to unify those? Either via a variable or an yaml anchor? Both would allow override if need be, but prevent unsynchronized changes by default

this comment is still open ;-)

@ehelms ehelms force-pushed the copr-projects branch 2 times, most recently from 6ecfae8 to 91658e9 Compare August 11, 2023 12:11
@ehelms
Copy link
Member Author

ehelms commented Aug 11, 2023

Check it now, I added some variables.

@evgeni
Copy link
Member

evgeni commented Aug 11, 2023

heh, doing things behind my back while I review…

LGTM!

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formal ack, yada yada ;)

@ehelms ehelms merged commit 27a95a1 into theforeman:rpm/develop Aug 11, 2023
1 check passed
@ehelms
Copy link
Member Author

ehelms commented Aug 11, 2023

Hooray -- I have jobs created for this theforeman/jenkins-jobs#343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants