-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the installer into multiple subpackages & add Pulp installer #8814
base: rpm/develop
Are you sure you want to change the base?
Conversation
Requires: %{?scl_prefix}rubygem(kafo) >= 6.5.0 | ||
Requires: %{?scl_prefix}rubygem(kafo) < 7.0.0 | ||
Requires: %{?scl_prefix_ruby}ruby(release) | ||
Requires: %{name}-scenario-foreman = %{epoch}:%{version}-%{release} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not expecting this part, that foreman-installer main package would have a requires on a scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still debated this in my head. I first wrote it here for compatibility or upgrades. Initially when I wrote this PR I really wanted to create a pulp installer and the split part was mostly to have a decent base to work on.
Perhaps we should not have foreman-installer
as a real package anymore at all, just make all the scenarios Provide: foreman-installer = %{version}
?
|
||
%files katello-common | ||
%{_datadir}/%{name}/katello-certs | ||
%{parser_cache}/foreman-proxy-certs.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you have this line in two places, katello-common and scenario-katello. I was leaning towards these two items should be included in either:
- scenario-katello
- foreman-installer-scenario-katello-certs (new sub-package)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be right. I wasn't sure where we want to use this. Perhaps we shouldn't even name it an installer scenario and just make it katello-certs
or something, since there's no separate scenario file it doesn't store any answers. It just provides a script to generate the certificates that could in theory also be used in some standalone server (like an offline CA).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we consider the downstream scenario then its own package makes sense.
Note to self: this is missing This came up in https://bugzilla.redhat.com/show_bug.cgi?id=2162704 |
This creates separate RPMs for each scenario. This allows the user to install just a single scenario and never use the --scenario parameter.
1d984fd
to
8470c11
Compare
Needs theforeman/foreman-installer#822.
To test:
Note that in my repo I haven't built the latest changes yet so you still need to hack the repo yourself.