Refs #37883 - wrap evr remote checks in method #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Nov 20, 2024
| end | ||
|
|
||
| check_remote_evr_extension_permissions |
There was a problem hiding this comment.
I wonder if we should have guards here
Suggested change
| check_remote_evr_extension_permissions | |
| check_remote_evr_extension_permissions if !local_postgresql? && katello_enabled? |
There was a problem hiding this comment.
The guards are in the method currently -- https://github.com/theforeman/foreman-installer/pull/999/files#diff-690025616ae0636f98279c9e319051813fa73ee28f489541b4dd89b2662756acR3-R4
There was a problem hiding this comment.
I wasn't quite sure what's nicer. It probably doesn't really matter.
What does matter is the trailing whitespace failure that breaks RuboCop.
ehelms
approved these changes
Nov 21, 2024
|
Thanks for cleaning the PR up @ekohl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix the issue mentioned here https://github.com/theforeman/foreman-installer/pull/984/files#r1851069746
Wraps all the code in a method and calls the method at the end.
Untested since I'm posting this right at the end of the day in case it can merge early.