Foreman 3.12.1 cherry picks #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenJDK 17's keytool now requires the keyalg parameter. EL 9.5 has made OpenJDK 17 the default version which means it broke fresh Katelllo installations. (cherry picked from commit 3af9f20)
This moves the code around to easily test the logic without making actual changes to the logic. Arguably this also makes the hook itself easier to read. (cherry picked from commit 10647cd)
Java < 11 uses version 1.X where X is the major while Java 11 drops the old 1. prefix. (cherry picked from commit 4c89c65)
…tes" This reverts commit 914c3cb because OpenSSL on EL8 doesn't support the `-no-CApath` option.
evgeni
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for OpenJDK 17, which became default on EL 9.5 and broke Katello installations. It also reverts 914c3cb because OpenSSL on EL8 doesn't support the
-no-CApathoption. Rather than trying to detect the support, this keeps it simple.