Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #37803 - Remove ProxyCommand option from Ansible options #993

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

adamlazik1
Copy link
Contributor

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamruzicka it looks good to me, but I'd appreciate your approval too.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, please make the commit message Refs #37803 so they're properly related in Redmine.

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending commit message change

@adamlazik1
Copy link
Contributor Author

Thank you @ekohl and @adamruzicka. Changed the commit message.

@ekohl ekohl changed the title Add migration reflecting recent puppet-foreman_proxy changes Refs #37803 - Remove ProxyCommand option from Ansible options Nov 21, 2024
@ekohl ekohl merged commit 349e482 into theforeman:develop Nov 21, 2024
8 checks passed
@ekohl
Copy link
Member

ekohl commented Nov 21, 2024

Thanks! I took the liberty to refine it a bit further.

@adamlazik1 adamlazik1 deleted the add-migration branch November 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants