Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean web profile #2149

Merged
merged 3 commits into from
Nov 18, 2024
Merged

clean web profile #2149

merged 3 commits into from
Nov 18, 2024
+37 −2

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 15, 2024

  • add backend servername to web vhost
  • add backend name to downloads vhost
  • add dedicated website profile for web + downloads

@evgeni evgeni force-pushed the clean-web-profile branch 2 times, most recently from bfe2b00 to cf9c338 Compare November 15, 2024 07:28
evgeni
evgeni commented Nov 15, 2024
View reviewed changes
puppet/modules/web/manifests/vhost/web.pp
Comment on lines +69 to +70
servername => "web-backend.${facts['networking']['fqdn']}",
serveraliases => ['theforeman.org', 'www.theforeman.org'],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same logic I did in #2124, with the long-term hope to move this thing to the CDN and not have those aliases pointing at the actual web machine anymore.

@ehelms ehelms merged commit ad76250 into master Nov 18, 2024
2 checks passed
@ehelms ehelms deleted the clean-web-profile branch November 18, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehelms ehelms ehelms approved these changes

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgeni @ekohl @ehelms