Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split common puppet data into common and internal #2130

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Split common puppet data into common and internal #2130

merged 1 commit into from
Oct 11, 2024

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 18, 2024

This implements a discussion: #2118 (comment)

The intent is to split what was in common.yaml into a file of data that changes rarely and data that tends to change more often.

@ehelms ehelms mentioned this pull request Sep 18, 2024
Merged
@ehelms
Copy link
Member Author

ehelms commented Oct 9, 2024

@ekohl when you get a chance, here is the split we discussed

ekohl
ekohl approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: https://github.com/theforeman/theforeman-rel-eng/blob/63830d794ec7f1dca482648fbe645fb210074eef/procedures/foreman/release.md.erb#L149C43-L149C55 remains correct.

@ekohl ekohl merged commit 674f4c1 into theforeman:master Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehelms @ekohl