Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to split out letsencrypt certificate setup since we are splitting up our web content across multiple servers. In the current format, this will fail to setup rpm and debian content servers. I am aiming to introduce a reusable defines to solve this but it does present a conundrum still. In theory the various vhosts are independent, but the certificate that gets generated is tied to the machine so that we have a single entity but requires knowledge of the vhosts.
Should I instead be doing this at the profile level? Is that leaking internals to the profile?