Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out letsencrypt for web #2126

Closed
wants to merge 1 commit into from
Closed

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 17, 2024

We need to split out letsencrypt certificate setup since we are splitting up our web content across multiple servers. In the current format, this will fail to setup rpm and debian content servers. I am aiming to introduce a reusable defines to solve this but it does present a conundrum still. In theory the various vhosts are independent, but the certificate that gets generated is tied to the machine so that we have a single entity but requires knowledge of the vhosts.

Should I instead be doing this at the profile level? Is that leaking internals to the profile?

@evgeni
Copy link
Member

evgeni commented Sep 18, 2024

How about #2129, it's more radical, but also IMHO more correct.

@ehelms
Copy link
Member Author

ehelms commented Sep 18, 2024

#2129 looks good to me!

@ehelms ehelms closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants