-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop EL8 support from our codebase #2106
Conversation
unless $facts['os']['family'] == 'RedHat' and $facts['os']['release']['major'] == '8' { | ||
stdlib::ensure_packages(['htop', 'iftop', 'screen']) | ||
} | ||
stdlib::ensure_packages(['htop', 'iftop', 'screen']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
screen
is back in EL9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Which makes me wonder if the utility
class is properly applied, as the EL9 boxen do not drop any errors but that should have been applied there already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a very good chance I somehow missed this. It's supposed to be applied via the Foreman ENC because we don't have the admins in Hiera (for privacy reasons). #1789 was intended to solve that but as you can see, that's been open for a while.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, screen
IS in EPEL. But we could also just take tmux from baseos?
(but the utility class is still not correctly applied)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add utility
to the base
config group, but that'd mean we need EPEL on all (EL) systems, which we today don't do.
No description provided.