Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby 2.7 to 2.7.8 #2001

Closed
wants to merge 1 commit into from
Closed

Conversation

wbclark
Copy link
Contributor

@wbclark wbclark commented Dec 18, 2023

Trying to resolve an issue with Katello/katello#10824

In CI, that was failing with:

[2023-12-12T21:28:51.917Z] Error:

[2023-12-12T21:28:51.917Z] CdnResourceTest#test_http_downloader_tlsv13:

[2023-12-12T21:28:51.917Z] NameError: uninitialized constant OpenSSL::SSL::TLS1_3_VERSION

[2023-12-12T21:28:51.917Z] Did you mean?  OpenSSL::SSL::TLS1_1_VERSION

[2023-12-12T21:28:51.917Z]                OpenSSL::SSL::TLS1_2_VERSION

[2023-12-12T21:28:51.917Z]                OpenSSL::SSL::TLS1_VERSION

[2023-12-12T21:28:51.917Z]                OpenSSL::SSL::SSL3_VERSION

[2023-12-12T21:28:51.917Z]     /home/jenkins/workspace/katello-pr-test/app/lib/katello/resources/cdn.rb:115:in `const_get'

[2023-12-12T21:28:51.917Z]     /home/jenkins/workspace/katello-pr-test/app/lib/katello/resources/cdn.rb:115:in `http_downloader'

[2023-12-12T21:28:51.917Z]     /home/jenkins/workspace/katello-pr-test/test/lib/resources/cdn_test.rb:24:in `test_http_downloader_tlsv13'

In nightlies and in my dev environment, with ruby 2.7.8, that issue is not occurring.

@evgeni
Copy link
Member

evgeni commented Dec 18, 2023

@ekohl @ehelms any one of you recall why we have .4 here? .8 is what's in EL8…

@ekohl
Copy link
Member

ekohl commented Dec 18, 2023

You bumped it in 989ad92 and #1793 doesn't say anything about why .4 was chosen. It wasn't the latest version at the time, given https://www.ruby-lang.org/en/downloads/releases/ says 2.7.6 was already out at that point.

Having said that:

[2023-12-12T21:28:51.917Z] NameError: uninitialized constant OpenSSL::SSL::TLS1_3_VERSION

This isn't going to work on our EL7 builders since the OpenSSL version there is too old.

@wbclark
Copy link
Contributor Author

wbclark commented Dec 20, 2023

@ekohl Is there an existing plan or issue to track upgrading builders off of EL7?

I'm disabling that TLS1_3_VERSION unit test in my PR and need to create an issue to re-enable it when it's feasible to do so.

@wbclark
Copy link
Contributor Author

wbclark commented Dec 20, 2023

Also, should this PR be closed, or is it safe to merge given that Ruby 2.7.8 is what users are getting when they install the latest Foreman and Katello builds?

@evgeni
Copy link
Member

evgeni commented Dec 20, 2023

You bumped it in 989ad92 and #1793 doesn't say anything about why .4 was chosen. It wasn't the latest version at the time, given https://www.ruby-lang.org/en/downloads/releases/ says 2.7.6 was already out at that point.

Ah, 2.7.4 is the Ruby in Debian buster, this is why I used it.

@ekohl
Copy link
Member

ekohl commented Dec 21, 2023

@ekohl Is there an existing plan or issue to track upgrading builders off of EL7?

#1706

I'm disabling that TLS1_3_VERSION unit test in my PR and need to create an issue to re-enable it when it's feasible to do so.

You can check if constants are defined. We do a similar thing here:
https://github.com/theforeman/smart-proxy/blob/2fb6db34f8726df3e8b276c4ced0542fd296bc6a/lib/launcher.rb#L72-L75

That way it gets enabled if TLS 1.3 is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants