Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate rss stats collection #1697

Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Dec 13, 2021

No description provided.

Copy link
Member

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bash-fu isn't the best but makes sense to me.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we rotate by YYYYMMDD (which is good). lognum made me thing we still used the old .n part which would cause problems here.

puppet/modules/web/files/rss-stat.sh Outdated Show resolved Hide resolved
@evgeni evgeni force-pushed the replace-tbrisker-with-a-small-shellscript branch from e77374f to af267a4 Compare December 13, 2021 11:44
@evgeni evgeni force-pushed the replace-tbrisker-with-a-small-shellscript branch from af267a4 to ae9266b Compare December 13, 2021 11:50
mode => '0750',
}

file { '/etc/cron.weekly/rss-stat':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is created via /etc/logrotate.d/httpd. I'm not sure I want to modify that, but I wonder if that would be better. I'm a bit worried that if we run this weekly and logrotate runs weekly that it may be a week behind most of the time (because cron would run before logrotate and then wait a week).

Still, we keep 4 weeks of backlog so it won't really be a big problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When talking to @tbrisker, we both agreed that making this executed from logrotate directly would be cool, but none of us is well-versed in logrotate and I always found it rather awful to debug, so didn't want to touch.

And yes, this makes us probably lag by a week, but then again, right now we lag by 3 weeks until @tbrisker does it ;)

@evgeni evgeni merged commit b125154 into theforeman:master Dec 13, 2021
@evgeni evgeni deleted the replace-tbrisker-with-a-small-shellscript branch December 13, 2021 13:12
@ehelms ehelms linked an issue Dec 13, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate pulling of RSS statistics from the website
3 participants