defn: suplattices, basic covers #336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncfavier
reviewed
Jan 6, 2024
| The notion of basic cover we formalise is from the work of Ciraulo, | ||
| Maietti and Sambin [-@CMS:2012], who investigate it in a *predicative* | ||
| context. While the 1Lab globally assumes [[propositional resizing]], | ||
| relieving us of the predicativity concerns, the presentation by of |
There was a problem hiding this comment.
Suggested change
| relieving us of the predicativity concerns, the presentation by of | |
| relieving us of the predicativity concerns, the presentation of |
Comment on lines
+29
to
+31
| Unlike with the tangible difference [[join]] and [[meet]] semilattices, | ||
| even as objects, a partially ordered set is an inf-lattice precisely if | ||
| it is a [[suplattice]]. This module is dedicated to recording that fact, |
There was a problem hiding this comment.
I feel like this sentence is missing a word or something. Also we should link to join- and meet-semilattices, not joins and meets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines suplattices and suplattice morphisms and basic covers following this paper. I want to get to the tensor product of suplattices before this PR is mergeable but I have a terrible headache so let's try tomorrow.