Add quote offline function

[kotobuki09]

Added offline quotes function as default with 5 minutes refresh. Based on https://github.com/Mv0sKff/tabliss_offline_quotes/tree/main/src

https://i.imgur.com/8KOTu4m.jpeg

[the-wright-jamie]

Thank you for your contribution.

I'm unsure if this is the route I want to go down with this - I mentioned in #29 that if users wish to have hard-coded quotes they could use that fork which you mentioned. Additionally, in #80 I lay out a plan for the user to be able to upload their own JSON for the quotes. Perhaps it might be nice to have this in the interim, however I don't know the legality of using and hardwiring those quotes into the codebase.

In the meantime, if this is something we are serious about adding, please address the merge conflicts. It would probably be better though if you wait until I make my mind up before doing that.

Once again, thank you - at the very least it will help motivate me to get #80 going.

[kotobuki09]

For sure! I mean you implement both hard fixed for quote or let's people upload their own.
In the end, users can do whatever they want. Thank you for updating the addon!

[the-wright-jamie]

The goal is to improve and extend the customisation of Tabliss, so that's a fair point - perhaps this could be our default quotes. I'll sleep on it, but you make a good point.

I'll update you soon (hopefully)

[the-wright-jamie]

I will try and get a look at this tonight, sorry for the long wait and thank you for you patience.

[the-wright-jamie]

Hey @kotobuki09

Just got looking here, I appreciate the work done here. If I recall correctly, the purpose of this PR was to add in Quote Functionality as it had to be removed due to another API deprecation. Or was the purpose to get offline quotes, so there is access to them in any network condition? I don't remember now

If the purpose was just to regain quote functionality, I merged #147. I prefer that implementation over this one for the simple fact that I don't know about the licensing of distributing those quotes on the plugin stores. The other fork that I'm aware of can get away with it because they aren't distributing anything outside of GitHub. I don't know where they got it and what license it had.

If you're absolutely dead set on having these offline quotes however, I can look into it further. We'll have a discussion about it - don't fix the conflict until we have decided that we want to also add this in.