[Feature] Add support for NASA Astronomy Picture of the Day (APOD) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-wright-jamie
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Looks pretty good, you seem to be injecting the new API variable properly and even added it to the workflow. Please check that the date selector has dark mode working correctly (I am aware of Firefox having stylesheet issues, it's on the to-do list) and remove the yarn lock file and we should be good to good.
|
Looking good, I will dev test this before merging later (may be a few days) |
|
Your change has just been published to stores and you should see it locally soon. Thank you once again for your contribution. Just a small note, the images look a little blury on my end - is this just an effect of the APOD? I have a 4k display, so it could be that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtitle of PR
This PR allow users to set a picture from the NASA APOD as a background.
It requires an API key from https://api.nasa.gov/
The default behavior is to display the picture of the day.
The only available option is selecting a date.
The APOD returned by the API can be a video, in this case the displayed background is the video thumbnail
This is the original PR I made on tabliss : joelshepherd#621
Checklist
Developer Testing Evidence
Evidence of the PR is in action in the section below.
Evidence
Chrome
Firefox
Edge