generated from the-collab-lab/smart-shopping-list
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AM] Create Landing Page #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amalyam
added
enhancement
New feature or request
design sprint
design sprint from issue 14
labels
Mar 22, 2024
Visit the preview URL for this PR (updated for commit 90c0be7): https://tcl-69-smart-shopping-list--pr56-am-create-landing-pa-63ckcozg.web.app (expires Mon, 01 Apr 2024 23:04:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80 |
amalyam
changed the title
Move List page contents into ManageList
[AM] Create Landing Page
Mar 22, 2024
Nice work @amalyam |
krsnamara
approved these changes
Mar 25, 2024
thanks for the team effort on this @krsnamara @piecanoe ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change creates a landing page that links to the About page, allows users to sign in, and provides some basic design to introduce users to the purpose of the app. This change also moves the list of the user's lists to the List page, and makes some minor design/visual organization changes to the List page, removes Manage List from the navbar (as this page will be completely removed in a future update). Additionally, this change unlinks the Home page from Layout so that it can be styled differently, though it borrows some basic aspects from Layout.
Related Issue
Closes #55
Sub-issue of #14
Acceptance Criteria
Notes
Updates
Before
After
Testing Steps / QA Criteria
At the "/" route, users should see the home page design as pictured in the "after" images above. They should be able to click the "here" link to navigate to the About page to learn more about the app. They should also be able to sign in and sign out from this page. If not signed in, there should be text which says "Click 'Sign In' to register and get started: " with a button to do so. Once signed in, there should be text which says "Welcome back [User Name]!" with an adjacent sign out button, and below it, "View your lists [here]" which should take the user to the List page when the "here" button is clicked.
The list page should have a navbar with Home, List, and About options, "Select a list or create a new one" near the top of the page, with instructive text and a field to create a new list. After selecting a list with items, those items should display below.