Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AM] Create Landing Page #56

Merged
merged 19 commits into from
Mar 25, 2024
Merged

[AM] Create Landing Page #56

merged 19 commits into from
Mar 25, 2024

Conversation

amalyam
Copy link
Collaborator

@amalyam amalyam commented Mar 22, 2024

Description

This change creates a landing page that links to the About page, allows users to sign in, and provides some basic design to introduce users to the purpose of the app. This change also moves the list of the user's lists to the List page, and makes some minor design/visual organization changes to the List page, removes Manage List from the navbar (as this page will be completely removed in a future update). Additionally, this change unlinks the Home page from Layout so that it can be styled differently, though it borrows some basic aspects from Layout.

Related Issue

Closes #55
Sub-issue of #14

Acceptance Criteria

  • should have a link to the About page
  • should allow the user to sign in or indicate if the user is already signed in
  • should not have any details about user's specific lists
  • should have some visual details that begin to establish the look and feel of the app

Notes

Updates

Before

Screen Shot 2024-03-25 at 17 27 39
Screen Shot 2024-03-25 at 17 28 09
Screen Shot 2024-03-25 at 17 28 16
Screen Shot 2024-03-25 at 17 28 34
Screen Shot 2024-03-25 at 17 28 44

After

Screen Shot 2024-03-25 at 17 29 45
Screen Shot 2024-03-25 at 17 29 04
Screen Shot 2024-03-25 at 17 29 35

Testing Steps / QA Criteria

At the "/" route, users should see the home page design as pictured in the "after" images above. They should be able to click the "here" link to navigate to the About page to learn more about the app. They should also be able to sign in and sign out from this page. If not signed in, there should be text which says "Click 'Sign In' to register and get started: " with a button to do so. Once signed in, there should be text which says "Welcome back [User Name]!" with an adjacent sign out button, and below it, "View your lists [here]" which should take the user to the List page when the "here" button is clicked.

The list page should have a navbar with Home, List, and About options, "Select a list or create a new one" near the top of the page, with instructive text and a field to create a new list. After selecting a list with items, those items should display below.

@amalyam amalyam added enhancement New feature or request design sprint design sprint from issue 14 labels Mar 22, 2024
@amalyam amalyam self-assigned this Mar 22, 2024
Copy link

github-actions bot commented Mar 22, 2024

Visit the preview URL for this PR (updated for commit 90c0be7):

https://tcl-69-smart-shopping-list--pr56-am-create-landing-pa-63ckcozg.web.app

(expires Mon, 01 Apr 2024 23:04:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@amalyam amalyam changed the title Move List page contents into ManageList [AM] Create Landing Page Mar 22, 2024
@krsnamara krsnamara self-requested a review March 25, 2024 21:24
@amalyam amalyam marked this pull request as ready for review March 25, 2024 21:42
@krsnamara
Copy link
Collaborator

Nice work @amalyam

@amalyam amalyam requested a review from rmorabia March 25, 2024 21:51
@amalyam
Copy link
Collaborator Author

amalyam commented Mar 25, 2024

thanks for the team effort on this @krsnamara @piecanoe !

@amalyam amalyam merged commit 65c0126 into main Mar 25, 2024
2 checks passed
@amalyam amalyam deleted the am-create-landing-page branch March 25, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create landing page
2 participants