Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MF] Adding Router to List Name Buttons on Home Screen #32

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

krsnamara
Copy link
Collaborator

@krsnamara krsnamara commented Mar 14, 2024

Description

This code imports React Router Dom Link component into the SingleList.jsx file. The Link component wraps the button in the single list with the "/list" endpoint. This changes each list item on the Home screen so that now when selecting a list you are routed to that specific list page. There is some lag in waiting for the listPath to return the promise and show the correct items. This could be resolved with some kind of loading spinner in a future issue. You can see that the listPath is already passed to the List component in that the name in the greeting matches the specific List the User selects.

Related Issue

closes #31
sub-issue of #14

Acceptance Criteria

  • Make the lists on home page route to corresponding list items display page

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

Screen.Recording.2024-03-14.at.5.41.30.PM.mov

After

UI has changed a little with the default styling of and

Screen.Recording.2024-03-14.at.5.41.30.PM.mov

Testing Steps / QA Criteria

  • Confirm you can log into your firebase, if not at test deploy to access domains list in firebase permissions settings.
  • On Home page select any list you wish to navigate to.
  • You will be routed to that list page and see those items.
  • Navigate back to Home page and select another list you wish to visit.

@krsnamara krsnamara added enhancement New feature or request suggestion a suggestion for a new issue labels Mar 14, 2024
Copy link

Visit the preview URL for this PR (updated for commit c63857a):

https://tcl-69-smart-shopping-list--pr32-mf-list-name-link-to-0gnoif2s.web.app

(expires Thu, 21 Mar 2024 21:52:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@krsnamara krsnamara self-assigned this Mar 19, 2024
@krsnamara krsnamara marked this pull request as ready for review March 19, 2024 17:20
@krsnamara
Copy link
Collaborator Author

@hsiangj @amalyam @piecanoe Pull request ready for team review.

@krsnamara krsnamara added the design sprint design sprint from issue 14 label Mar 19, 2024
@krsnamara krsnamara merged commit eb0f6e9 into main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request suggestion a suggestion for a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Name Button Redirect
1 participant