Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Page Styling #61

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Home Page Styling #61

merged 11 commits into from
Apr 4, 2024

Conversation

DevinaG007
Copy link
Collaborator

@DevinaG007 DevinaG007 commented Apr 2, 2024

Description

Styled the home page of our shopping list app

  • Styled new list form
  • Styled list of lists
  • styled sign-in and sign-out buttons

Related Issue

closes #56

Acceptance Criteria

The following components should be styled according to our prototype:

  • Button: Sign In
  • Input Text Box: Add new list
  • Label: Add new list
  • Button: Create list
  • List Items: User's lists

Type of Changes

Enhancement

Updates

Before

image

After

image

Testing Steps / QA Criteria

  1. Verify that the styling changes made look similar to proto-type and clean on mobile view.
  2. Verify there are no errors or bugs with changes.

Copy link

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit f8b1436):

https://tcl-68-smart-shopping-list--pr61-dg-sm-home-page-styl-rvsk9lr0.web.app

(expires Thu, 11 Apr 2024 01:38:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84

Copy link
Collaborator

@andiedoescode andiedoescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as expected like the screenshots.

Nit (non-blocking): Sign in button is super wide in desktop view. I know we're focusing on the mobile view so this is not a priority.

Copy link
Collaborator

@etiry etiry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, looking good! A couple of minor/low-priority comments that I think we can do without for now if we run out of time.

src/components/SingleList.jsx Outdated Show resolved Hide resolved
src/views/Home.jsx Show resolved Hide resolved
@DevinaG007 DevinaG007 merged commit d317f60 into main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

26. Home Page Styling
4 participants