Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/padding, colors, borders #127

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

flbarfield
Copy link
Collaborator

@flbarfield flbarfield commented Apr 6, 2024

Description

Added color, padding, and border adjustments to be more in line with high-fidelity mocks. List view especially, but also adjusted the home page/header.

Also further separated mass CSS file into component files for the list view.

Related Issue

closes #126
closes #117
closes #112
closes #128

Acceptance Criteria

Visually resembles high fidelity mock ups.

Type of Changes

Enhancement

Updates

Before

old1

old2

After

new1

new2

Testing Steps / QA Criteria

Navigate through the views.

@flbarfield flbarfield added the enhancement New feature or request label Apr 6, 2024
@flbarfield flbarfield self-assigned this Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

Visit the preview URL for this PR (updated for commit 9abda60):

https://tcl-67-smart-shopping-list--pr127-enhancement-padding-btu1cnij.web.app

(expires Sat, 13 Apr 2024 17:00:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1dc6f6876568bd8a1c97781eec7984835c207f7c

Copy link
Collaborator

@aberger3647 aberger3647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so amazing 🤩🤩🤩

@aberger3647 aberger3647 merged commit f492ad0 into main Apr 6, 2024
3 checks passed
@adidalal adidalal deleted the enhancement/padding-colors-borders branch April 8, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants