Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to javalin 6.3.0 and openapi 6.3.0 #90

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

Nikita-Smirnov-Exactpro
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 10, 2024

Test Results

7 tests  ±0   7 ✅ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 70a3aaf. ± Comparison against base commit 1f82e21.

♻️ This comment has been updated with latest results.

@Nikita-Smirnov-Exactpro
Copy link
Member Author

Nikita-Smirnov-Exactpro commented Dec 10, 2024

After migration, nullable filed has been added for some objects' fields
openapi-default-old.json
openapi-default-new.json

@OptimumCode
Copy link
Member

After migration, nullable filed has been added for some objects' fields openapi-default-old.json openapi-default-new.json

Then we need to modify annotation to indicate whether they actually can be nullable or not

@Nikita-Smirnov-Exactpro
Copy link
Member Author

After migration, nullable filed has been added for some objects' fields openapi-default-old.json openapi-default-new.json

Then we need to modify annotation to indicate whether they actually can be nullable or not

Hm ... @get:OpenApiPropertyType(definedBy = ..., nullability = Nullability.NOT_NULL) doesn't affect to the "nullable":true in the openapi-default.json

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro marked this pull request as ready for review December 11, 2024 14:00
@Nikita-Smirnov-Exactpro
Copy link
Member Author

After migration, nullable filed has been added for some objects' fields openapi-default-old.json openapi-default-new.json

Then we need to modify annotation to indicate whether they actually can be nullable or not

Hm ... @get:OpenApiPropertyType(definedBy = ..., nullability = Nullability.NOT_NULL) doesn't affect to the "nullable":true in the openapi-default.json

Added annotations to source code.

I have applied strange approach to archive not required and not nullable

@get:OpenApiNullable(nullable = false) // this annotation is added to mark this field as not nullable if exist
@get:OpenApiPropertyType(definedBy = ..., nullability = Nullability.NULLABLE) // thia annotation is added to mark this field as optional 

openapi-default.json

@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro merged commit 355742b into dev-version-2 Dec 16, 2024
13 of 14 checks passed
@Nikita-Smirnov-Exactpro Nikita-Smirnov-Exactpro deleted the update-kotlin-1.9.22 branch December 16, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants