Any.toValue() / Any.toValueFilter() > Add support for sequences and s… #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+60
to
+61
| is Sequence<*> -> iterator().toValueFilter() | ||
| is Stream<*> -> iterator().toValueFilter() |
There was a problem hiding this comment.
Maybe use a base approach for Stream and Sequence. I mean .map(toValue).forEach(valueList::add)
There was a problem hiding this comment.
To do this we'll have to create ListValue first. So it's just better to reuse existing function which does exactly that
Topru333
reviewed
Jun 8, 2022
| } | ||
|
|
||
| Assertions.assertEquals(listOf(1, 2, 3, 4), message.getField("sequence")!!.listFilter.valuesList.map { it.simpleFilter.toInt() }) | ||
| Assertions.assertEquals(listOf(5, 6, 7, 8), message.getField("stream")!!.listFilter.valuesList.map { it.simpleFilter.toInt() }) |
There was a problem hiding this comment.
maybe is it time to implement list of primitive value util?
Something like
when (type) {
int -> message.getField("stream")!!.listFilter.valuesList.map { it.simpleFilter.toInt() }
}
There was a problem hiding this comment.
I'm not sure that it's a very common use-case. But if it - let's do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…treams