All harvesters load up reagents on afterattack #16360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
Quality of Life
fleewave
changed the title
|
Remove the argument instead, don't just do |
sure, good plan |
Xander3359
reviewed
Jul 18, 2024
code/datums/components/harvester.dm
Outdated
| @@ -30,18 +30,16 @@ | |||
| var/datum/action/harvester/reagent_select/reagent_select_action | |||
| ///The maximum amount that one chemical can be loaded | |||
| var/max_loadable_reagent_amount = 30 | |||
| var/loadup_on_attack = FALSE | |||
| var/loadup_on_attack = TRUE | |||
There was a problem hiding this comment.
Just delete this entirely and bake it in to default behaviour
There was a problem hiding this comment.
done, don't know why i didn't do this in the first place
As if auto loading could stop me from spamming unique-action, unless it were to send ~10 "Kelotane" messages when it's loaded i will continue to do so. |
Xander3359
approved these changes
Jul 18, 2024
So true bestie |
|
👀 |
|
👁️ 👄 👁️ |
TiviPlus
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
All Vali weapons will now autoload after hitting a target, as the claymore currently does.
Why It's Good For The Game
#12687 added autoloading, but only to the claymore. I don't see a reason why we can't have this on the rest of the harvester weapons as well, considering it doesn't add much of an advantage over spamming your unique-action key.
Changelog
🆑
qol: All harvester weapons now autoload chems after attacking.
/:cl: