Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Well-Known Prefix MUST NOT be used to represent non-global IPv4 addresses, such as RFC1918 #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

momoka0122y
Copy link
Contributor

@momoka0122y momoka0122y commented Nov 4, 2023

closes #32

Comment on lines 463 to 467
Note that some IPv4 prefixes are scoped to a given host or network, such as
0.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, and 255.255.255.255/32, and
therefore do not require NAT64 address synthesis.
Additionally, the Well-Known Prefix {{!RFC6052}} MUST NOT be used to represent
non-global IPv4 addresses, such as those defined in {{!RFC1918}}.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this whole paragraph should be at the end of the section for readability.

Be right before

Hostnames with Broken AAAA Records {#broken}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If rfc6052 already says this, why is it relevant for HEv3?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to point out the NAT requirement to tell the clients to not bother. I'd phrase it something like this:

Similarly, there are additional restrictions on the use of the well-known NAT64 prefix (see Section 3.1 of RFC 6052) so clients can skip NAT64 address synthesis in such cases that will be rejected by the NAT64 translator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you. That text is better as we are talking of client implementation.
If moving the text down also seems reasonable please merge ;)

@momoka0122y momoka0122y changed the title Update draft-pauly-v6ops-happy-eyeballs-v3.md The Well-Known Prefix MUST NOT be used to represent non-global IPv4 addresses, such as RFC1918 Nov 4, 2023
@@ -480,6 +476,11 @@ queries; connection attempts follow the algorithm described above
Such translation also applies to any IPv4 address hints received
in SVCB RRs.

Note that some IPv4 prefixes are scoped to a given host or network, such as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I fully understand the motivation for moving this down, but we can rearrange later editorially.

Note that some IPv4 prefixes are scoped to a given host or network, such as
0.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, and 255.255.255.255/32, and
therefore do not require NAT64 address synthesis.
Similarly, there are additional restrictions on the use of the well-known NAT64 prefix (see Section 3.1 of {{!RFC6052}}) so clients can skip NAT64 address synthesis in such cases that will be rejected by the NAT64 translator.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: This probably needs to wrap with the rest of the document (this is superseded by the suggested comment, though, so no worries).

Comment on lines +479 to +482
Note that some IPv4 prefixes are scoped to a given host or network, such as
0.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, and 255.255.255.255/32, and
therefore do not require NAT64 address synthesis.
Similarly, there are additional restrictions on the use of the well-known NAT64 prefix (see Section 3.1 of {{!RFC6052}}) so clients can skip NAT64 address synthesis in such cases that will be rejected by the NAT64 translator.
Copy link
Contributor

@ekinnear ekinnear Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this wording came from a previous comment, but perhaps something that would convey just the necessary bits would be something like:

Suggested change
Note that some IPv4 prefixes are scoped to a given host or network, such as
0.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, and 255.255.255.255/32, and
therefore do not require NAT64 address synthesis.
Similarly, there are additional restrictions on the use of the well-known NAT64 prefix (see Section 3.1 of {{!RFC6052}}) so clients can skip NAT64 address synthesis in such cases that will be rejected by the NAT64 translator.
Note that some IPv4 prefixes are scoped to a given host or network, such as
0.0.0.0/8, 127.0.0.0/8, 169.254.0.0/16, and 255.255.255.255/32, and there are
additional restrictions on the use of the well-known NAT64 prefix (see
{{Section 3.1 of !RFC6052}}), therefore NAT64 address synthesis might not be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Well-Known Prefix MUST NOT be used to represent non-global IPv4 addresses, such as RFC1918
4 participants