-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactivate tests and remove dead code #706
Conversation
thank you for this @vkresch I see small changes in src/. I can test for cycle 751 payouts. Then we can merge this. We can do a 13.1 release in a less rushed fashion. Anything else you'd like to do? I am considering removing all code for |
Thanks. During the test reactivation there were some Attribute not found errors of the PaymentProducer (for example self.exiting and self.payments_queue) so I moved the attribute definitions on top to avoid this. This should not break anything but please check and test this on your side.
I think it is good step to clean up and simplify the code base. I already liked the move to only Tzkt API. |
7a02889
to
8ee60f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It worked for me, I had to fix a few things for docker to work.
Thanks! |
Work effort: 8h
Review time: 1h (nochem)