Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate tests and remove dead code #706

Merged
merged 6 commits into from
Jul 10, 2024
Merged

Conversation

vkresch
Copy link
Contributor

@vkresch vkresch commented Jun 30, 2024

  • Reactivate and update tests and remove dead code
  • Removing tzpro and rpc code
  • Replacing depracted pkg_resource in python 3.12 with importlib.metadata:

Use of pkg_resources is deprecated in favor of importlib.resources, importlib.metadata and their backports (importlib_resources, importlib_metadata). Some useful APIs are also provided by packaging (e.g. requirements and version parsing). Users should refrain from new usage of pkg_resources and should work to port to importlib-based solutions.
Source: https://setuptools.pypa.io/en/latest/pkg_resources.html

Work effort: 8h
Review time: 1h (nochem)

@vkresch vkresch self-assigned this Jun 30, 2024
@vkresch vkresch marked this pull request as draft June 30, 2024 14:07
@vkresch vkresch marked this pull request as ready for review June 30, 2024 18:03
@vkresch vkresch changed the title [WIP] Reactivate tests and remove dead code Reactivate tests and remove dead code Jun 30, 2024
@nicolasochem
Copy link
Contributor

thank you for this @vkresch

I see small changes in src/. I can test for cycle 751 payouts. Then we can merge this.

We can do a 13.1 release in a less rushed fashion. Anything else you'd like to do?

I am considering removing all code for owner and founder since it no longer makes sense in Paris protocol. See discussion on baking slack. Any thoughts on this? @vkresch @jdsika

@vkresch
Copy link
Contributor Author

vkresch commented Jun 30, 2024

Thanks. During the test reactivation there were some Attribute not found errors of the PaymentProducer (for example self.exiting and self.payments_queue) so I moved the attribute definitions on top to avoid this. This should not break anything but please check and test this on your side.

I am considering removing all code for owner and founder since it no longer makes sense in Paris protocol. See discussion on baking slack. Any thoughts on this? @vkresch @jdsika

I think it is good step to clean up and simplify the code base. I already liked the move to only Tzkt API.

Copy link
Contributor

@nicolasochem nicolasochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It worked for me, I had to fix a few things for docker to work.

@nicolasochem nicolasochem merged commit 726a3a7 into master Jul 10, 2024
9 checks passed
@nicolasochem nicolasochem deleted the reactivate_tests branch July 10, 2024 05:05
@vkresch
Copy link
Contributor Author

vkresch commented Jul 10, 2024

Thanks! It worked for me, I had to fix a few things for docker to work.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants