Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: alwaysRun should not force invocation of Before-methods #2198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kool79
Copy link

@kool79 kool79 commented Nov 23, 2019

Resolves #1622

Did you remember to?

  • [-] Add test case(s)
  • Update CHANGES.txt

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@krmahadevan
Copy link
Member

@kool79 - thanks for helping with raising a PR. Can you please include tests as well?

@juherr - please help review. I am out this weekend.

@krmahadevan krmahadevan requested a review from juherr November 24, 2019 09:42
Copy link
Member

@krmahadevan krmahadevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests that are failing in this PR. Also please help include a test.

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a non-regression test for the feature too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Parameter alwaysRun=true for before-methods forces execution of those methods
3 participants