Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter alwaysRun=true for before-methods forces execution of those methods #1633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krmahadevan
Copy link
Member

Closes #1622

Fixes #1622 .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

@krmahadevan krmahadevan requested a review from juherr December 1, 2017 01:17
@juherr
Copy link
Member

juherr commented Mar 28, 2018

@krmahadevan Did you plan to update this PR according to #1622 (comment) ?
You can revert #683 if needed (but keep the test case)

@krmahadevan
Copy link
Member Author

@juherr - I will come back to this hopefully during this weekend and see what I can do with respect to this issue.

@aTan-aka-Xellos
Copy link

@krmahadevan @juherr Hello! Any updates on this PR? Also having troubles because of #1622 issue :(

@krmahadevan
Copy link
Member Author

@aTan-aka-Xellos - Thanks for reminding me on this. Let me see if I can get around to this over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Parameter alwaysRun=true for before-methods forces execution of those methods
3 participants