-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: Update deps #777
base: main
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: min supported version of node is 12.22
❌ Deploy Preview for react-hooks-testing-library failed. 🔨 Explore the source changes: 416d475 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-hooks-testing-library/deploys/61efcdc260b71200088417d4 |
This is a strange error to have... |
The rules not being found? I believe |
I think you're right. Let me add it to the PR and we'll go from there, as it's (annoyingly) not throwing said error in my env. |
I've just done a quick whip around of a few big react libraries written in TS that I'm aware of and it does appear to be the case that most just list the types as The only one I could find doing it the way I'm proposing it should be done is material-ui. I'm still of the opinion that this is the the better way to handle it as it will give a peer dependency warning if the wrong version is installed, but not complain if the type dependencies are not required (e.g. non-TS users). I've checked out generated type definitions and only |
What:
Why:
How:
Checklist: