Add hint to allow retry after previous cached failure to find Docker environment #7533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6441
As per the linked issue, the original behaviour to disable retries to find a valid Docker environment was introduced in #456
However, this can lead to frustrating situations where it becomes impossible to rerun builds if testcontainers was ever accidentally run without a valid Docker environment present. This happens when a long-running daemon (eg, Gradle daemon) keeps the testcontainers classes around and the
FAIL_FAST_ALWAYS
flag is never cleared.I don't think it's worth adding special commands to somehow reset this flag, and the original fix sounds like it addresses a valid problem.
If the maintainers think that it's worth it, it may be worth considering changing the
FAIL_FAST_ALWAYS
boolean to a timestamp and essentially cache the failure for a limited time, rather than forever. This at least provides an upper bound for the number of unnecessary pings to check a Docker environment.My current PR simply adds a hint to users about why testcontainers is never retrying, and how to force a retry.