formatter: Add source attribute in the checkstyle format #2078
+17
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2056
Currently, the
checkstyle
output format uses therule
attribute as the rule name.However, the original Checkstyle XML output format uses the
source
attribute as the issue identifier.https://github.com/checkstyle/checkstyle/blob/a7042e5119e6df9b8f782751af6cae2ee54a215a/src/main/java/com/puppycrawl/tools/checkstyle/XMLLogger.java#L205-L224
Several tools rely on the original format shown above, so TFLint adds the
source
attribute as well.The
rule
attribute will remain for backwards compatibility, but will be removed in the future. Tools that rely on its value are encouraged to switch to thesource
attribute as soon as possible.