feat: Support aws_fsx_lustre_file_system.efa_enabled
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Dec 22, 2024
modules/lustre/main.tf
Outdated
| @@ -87,6 +88,7 @@ resource "aws_cloudwatch_log_group" "this" { | |||
| retention_in_days = var.cloudwatch_log_group_retention_in_days | |||
| kms_key_id = var.cloudwatch_log_group_kms_key_id | |||
| log_group_class = var.cloudwatch_log_group_class | |||
| skip_destroy = var.cloudwatch_log_group_skip_destroy | |||
There was a problem hiding this comment.
lets remove this - it doesn't make sense to skip log groups, it will only cause conflicts
magreenbaum
changed the title
aws_fsx_lustre_file_system.efa_enabled and aws_cloudwatch_log_group.skip_destroyaws_fsx_lustre_file_system.efa_enabled
bryantbiggs
approved these changes
Dec 23, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Dec 23, 2024
## [1.2.0](v1.1.1...v1.2.0) (2024-12-23) ### Features * Support `aws_fsx_lustre_file_system.efa_enabled` ([#6](#6)) ([e172a5b](e172a5b))
|
This PR is included in version 1.2.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
aws_fsx_lustre_file_system.efa_enabled.Motivation and Context
Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request