Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct mis-spelled output volumes on Ontap sub-module #3

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

relivnd
Copy link
Contributor

@relivnd relivnd commented Jun 7, 2024

Description

There's a typo in the output variable volume of this module. It's named volues.

Motivation and Context

One wouldn't expect to be a typo there. My VS Code code completion plugin even proposed volumes written the right way. It's a trap for people who start using the module who're required to access the volumes attribute.

Breaking Changes

There might be braking changes for people who:

  • use the module but haven't pinned down the version and use the volues output variable

How Has This Been Tested?

Since it's only the name of an output, I tested it locally and the change worked fine for me

@relivnd relivnd changed the title fix(): fix typo in volumes fix(): Typo in volumes Jun 11, 2024
@bryantbiggs bryantbiggs changed the title fix(): Typo in volumes fix: Correct mis-spelled output volumes on Ontap sub-module Jun 11, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 4c15bdd into terraform-aws-modules:master Jun 11, 2024
13 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 11, 2024
## [1.0.2](v1.0.1...v1.0.2) (2024-06-11)

### Bug Fixes

* Correct mis-spelled output `volumes` on Ontap sub-module ([#3](#3)) ([4c15bdd](4c15bdd))
@antonbabenko
Copy link
Member

This PR is included in version 1.0.2 🎉

@relivnd relivnd deleted the patch-1 branch June 11, 2024 12:54
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants