Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add lifecycle ignore userdata as otherwise reboots existing instances #411

Conversation

adavis-sdx
Copy link

Description

Add instance Lifecycle rule to ignore user_data changes.

Motivation and Context

There are times when I want to update the userdata and not replace the existing instances (which can be achieved with user_data_replace_on_change) but also not reboot the existing instances which is the case if not replaced. We can't be rebooting tens of instances for a small change we want applied to any new instances and if we want it applied to all instances then a replace is required anyway

Breaking Changes

No

How Has This Been Tested?

  • [ X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [X ] I have tested and validated these changes using one or more of the provided examples/* projects
  • [X ] I have executed pre-commit run -a on my pull request

@adavis-sdx adavis-sdx changed the title Add lifecycle ignore userdata as otherwise reboots existing instances feat: Add lifecycle ignore userdata as otherwise reboots existing instances Oct 31, 2024
@adavis-sdx
Copy link
Author

Sorry, I know it is not good having more resources just to be able to add this "lifecycle ignore" entry but as it is not possible to pass anything but a static list it would seem like the only way. I would have loved to make it dynamic if that was supported.

@bryantbiggs
Copy link
Member

unfortunately, this doesn't make sense. perhaps a different architecture is better suited (i.e. - using autoscaling groups)

@bryantbiggs bryantbiggs closed this Nov 2, 2024
@adavis-sdx adavis-sdx deleted the feature/ignore-userdata branch November 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants