feat: Add support for capacity block #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required for capacity block
add ability to read it in
Pchatain
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
|
Hey we rely on this branch because capacity blocks are broken without it. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the ec2-instance template terraform, I add the ability to assign
instance_market_options.Motivation and Context
When I tried to deploy an EC2 instance into a capacity block, I got this error
I found this github issue which contained most of what I needed to fix this error.
Breaking Changes
This should not have any breaking changes since it adds optional functionality.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI tested this change on our private repository where I deployed an EC2 instance into a capacity block.
pre-commit run -aon my pull request