Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setting var.launch_template doesn't work due to default ami and instance_type vars #378

Closed
wants to merge 1 commit into from

Conversation

alisson276
Copy link

@alisson276 alisson276 commented Feb 21, 2024

Description

If ami or instance_type are set (and they are by default) passing launch_template to the module doesn't work.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@alisson276 alisson276 changed the title fix: setting var.launch_template doesn't work due to default ami and instance_type vars fix: Setting var.launch_template doesn't work due to default ami and instance_type vars Feb 21, 2024
@alisson276
Copy link
Author

alisson276 commented Feb 21, 2024

The only problem with this solution is if the launch template has no ami or instance_type it won't work. What do you suggest?

I thought putting a "flag" would work, like override_ami = true, but I don't like the idea of introducing new variables

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 23, 2024
Copy link

github-actions bot commented Apr 2, 2024

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Apr 2, 2024
Copy link

github-actions bot commented May 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant