Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow multiple traffic source attachments #273

Conversation

Yethal
Copy link
Contributor

@Yethal Yethal commented Jun 25, 2024

Description

  • target_group_arns and load_balancers are no longer supported on the ASG; instead users should use the traffic_source_attachments which cover this functionality and more
  • Users can now create multiple traffic_source_attachments instead of previously where the module only supported one attachment
  • The minimum supported version of Terraform has been raised to v1.3

Motivation and Context

Breaking Changes

  • Yes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@Yethal Yethal changed the title Allow multiple traffic source attachments feat: Allow multiple traffic source attachments Jun 25, 2024
@Yethal
Copy link
Contributor Author

Yethal commented Jun 27, 2024

@antonbabenko Can we merge this?

Copy link

github-actions bot commented Aug 5, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 5, 2024
@Yethal
Copy link
Contributor Author

Yethal commented Aug 5, 2024

@antonbabenko Can we merge this?

@github-actions github-actions bot removed the stale label Aug 6, 2024
…ws-autoscaling into allow_multiple_traffic_source_attachments
@bryantbiggs bryantbiggs changed the title feat: Allow multiple traffic source attachments feat!: Allow multiple traffic source attachments Aug 13, 2024
@bryantbiggs bryantbiggs force-pushed the allow_multiple_traffic_source_attachments branch from bac266a to d85fba6 Compare August 13, 2024 22:16
@bryantbiggs bryantbiggs merged commit 3782413 into terraform-aws-modules:master Aug 13, 2024
7 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 13, 2024
## [8.0.0](v7.7.0...v8.0.0) (2024-08-13)

### ⚠ BREAKING CHANGES

* Allow multiple traffic source attachments (#273)

### Features

* Allow multiple traffic source attachments ([#273](#273)) ([3782413](3782413))
@antonbabenko
Copy link
Member

This PR is included in version 8.0.0 🎉

@Yethal Yethal deleted the allow_multiple_traffic_source_attachments branch August 14, 2024 06:10
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_traffic_source_attachment does not work as expected
3 participants