Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Argument update_default_version type should be a bool #272

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix: Argument update_default_version type should be a bool #272

merged 2 commits into from
Jun 20, 2024

Conversation

cedarkuo
Copy link
Contributor

Description

The update_default_version variable is currently defined as a string in the code, but the documentation suggests setting it as a boolean value. To resolve the inconsistency between the documentation and the code, the type of the update_default_version variable could be updated from string to bool.

@bryantbiggs bryantbiggs changed the title Update update_default_version type fix: update_default_version type type should be a bool Jun 20, 2024
@bryantbiggs bryantbiggs changed the title fix: update_default_version type type should be a bool fix: update_default_version type should be a bool Jun 20, 2024
@bryantbiggs bryantbiggs changed the title fix: update_default_version type should be a bool fix: Argument update_default_version type should be a bool Jun 20, 2024
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit 28521c4 into terraform-aws-modules:master Jun 20, 2024
6 of 9 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 20, 2024
## [7.6.1](v7.6.0...v7.6.1) (2024-06-20)

### Bug Fixes

* Argument `update_default_version` type should be a `bool` ([#272](#272)) ([28521c4](28521c4))
@antonbabenko
Copy link
Member

This PR is included in version 7.6.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants