feat: Adds max_healthy_percentage and skip_matching to autoscaling group
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcentage attribute support was added and allow configuring max_healthy_percentage
…es examples to look for Amazon Linux 2 AMIs since Amazon Linux AMIs are already end of life.
bryantbiggs
reviewed
Feb 21, 2024
| @@ -4,7 +4,7 @@ terraform { | |||
| required_providers { | |||
| aws = { | |||
| source = "hashicorp/aws" | |||
| version = ">= 5.26" | |||
| version = ">= 5.32" | |||
There was a problem hiding this comment.
we need to change this throughout - aligning all of the examples as well
There was a problem hiding this comment.
Thanks! I've updated the required version in the examples and updated the docs. Let me know if there anything else I've missed :)
antonbabenko
pushed a commit
that referenced
this pull request
Feb 21, 2024
## [7.4.0](v7.3.1...v7.4.0) (2024-02-21) ### Features * Adds `max_healthy_percentage` and `skip_matching` to autoscaling group ([#256](#256)) ([faf98ef](faf98ef))
|
This PR is included in version 7.4.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
max_healthy_percentageandskip_matchingtoaws_autoscaling_groupinstance_refresh.preferences.Small aside: also updated the examples to look for an Amazon Linux 2 AMI rather than an Amazon Linux AMI which is EOL.
Motivation and Context
These two settings were added in the AWS Terraform provider and currently there is no way to specify them using this module.
max_healthy_percentagewas added in v5.32.0 (see changelog)and
skip_matchingwas added in v4.13.0 (see changelog)Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request