Busybox: Enable IPv6 and some applets #22431
Open
+59
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomJo2000
approved these changes
Dec 17, 2024
| # CONFIG_NTPD is not set | ||
| CONFIG_NSLOOKUP=n | ||
| CONFIG_FEATURE_NSLOOKUP_BIG=n | ||
| CONFIG_FEATURE_NSLOOKUP_LONG_OPTIONS=n |
There was a problem hiding this comment.
Is there a particular reason to set these to n instead of leaving them commented out?
| # CONFIG_IFUP is not set | ||
| # CONFIG_IFDOWN is not set | ||
| CONFIG_IFUP=y | ||
| CONFIG_IFDOWN=y |
There was a problem hiding this comment.
IFUP and IFDOWN won't work without root access, right?
| CONFIG_NSLOOKUP=n | ||
| CONFIG_FEATURE_NSLOOKUP_BIG=n | ||
| CONFIG_FEATURE_NSLOOKUP_LONG_OPTIONS=n | ||
| CONFIG_NTPD=y |
There was a problem hiding this comment.
Would ntpd even work on Android?
| @@ -559,7 +559,7 @@ CONFIG_FEATURE_DEFAULT_PASSWD_ALGO="" | |||
| # Linux Ext2 FS Progs | |||
| # | |||
| CONFIG_CHATTR=y | |||
| # CONFIG_FSCK is not set | |||
| CONFIG_FSCK=y | |||
There was a problem hiding this comment.
Is fsck useful on Android?
I'm also assuming it would require root privileges.
| @@ -1002,22 +1002,22 @@ CONFIG_FEATURE_WGET_TIMEOUT=y | |||
| # CONFIG_FEATURE_WGET_OPENSSL is not set | |||
| CONFIG_WHOIS=y | |||
| # CONFIG_ZCIP is not set | |||
| # CONFIG_UDHCPD is not set | |||
| CONFIG_UDHCPD=y | |||
There was a problem hiding this comment.
I'm not sure udhcpd would work without root, or at all on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.