-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(call-log): Fix query call log raise Exception #440
base: master
Are you sure you want to change the base?
Conversation
According to https://android.googlesource.com/platform/frameworks/base/+/fd02074fdd12039e905a515941ffd9a757f671c2/core/java/android/database/sqlite/SQLiteQueryBuilder.java#162 Google restrict his way to limit query call log with sql statement, So we should use new method to query call log: https://developer.android.com/reference/android/content/ContentProvider#query(android.net.Uri,%20java.lang.String[],%20android.os.Bundle,%20android.os.CancellationSignal) Signed-off-by: KunoiSayami <[email protected]>
Signed-off-by: KunoiSayami <[email protected]>
I have no idea how this works, probably you can review this @Grimler91 |
There is a number of identical statements under |
I tried by I failed, maybe you will have a better way to refactor it |
The offset parameter doesn't work with this implementation, and there is an issue with the sort descending arg:
For the latter, maybe QUERY_ARG_SORT_COLUMNS should be used instead of QUERY_ARG_SQL_SORT_ORDER. I've played around with it but haven't managed to solve the offset issue, yet |
According to
https://android.googlesource.com/platform/frameworks/base/+/fd02074fdd12039e905a515941ffd9a757f671c2/core/java/android/database/sqlite/SQLiteQueryBuilder.java#162
Google restrict his way to limit query call log with sql statement,
So we should use new method to query call log:
https://developer.android.com/reference/android/content/ContentProvider#query(android.net.Uri,%20java.lang.String[],%20android.os.Bundle,%20android.os.CancellationSignal)
termux-call-log
doesn't work #434Signed-off-by: KunoiSayami [email protected]