fix(compress.py): use single value table for per-tensor quantized tensors #3025
+164
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sors Compress using a single value table when a tensor is per-tensor quantized, as indicated by the presence of only one quantization scale and zero point. Update unit tests accordingly and augment `test_models` to accommodate additional quantization fields. Abandon the logic that a tensor should be compressed along the NHWC channel dimension if the quantization parameters do not specify an axis. Instead, fail with an error if the compression axis cannot be inferred from the quantization parameters. The interpreter already expects a single value table when a tensor is per-tensor quantized. BUG=part of tensorflow#2636
suleshahid
approved these changes
Dec 19, 2024
|
https://github.com/Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compress using a single value table when a tensor is per-tensor
quantized, as indicated by the presence of only one quantization
scale and zero point. Update unit tests accordingly and augment
test_modelsto accommodate additional quantization fields.Abandon the logic that a tensor should be compressed along the
NHWC channel dimension if the quantization parameters do not
specify an axis. Instead, fail with an error if the compression
axis cannot be inferred from the quantization parameters.
The interpreter already expects a single value table when a
tensor is per-tensor quantized.
BUG=part of #2636