Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compression): add decompression library #2996

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

rkuester
Copy link
Contributor

@rkuester rkuester commented Dec 7, 2024

Add a decompression library, defining structures for compressed
tensors and decompression logic to be used by kernels. Add a unit
test to validate decompression logic.

BUG=part of #2636

Add a decompression library, defining structures for compressed
tensors and decompression logic to be used by kernels. Add a unit
test to validate decompression logic.

BUG=part of tensorflow#2636
@rkuester rkuester requested a review from a team as a code owner December 7, 2024 00:56
@rkuester rkuester marked this pull request as draft December 7, 2024 01:30
@rkuester rkuester marked this pull request as ready for review December 7, 2024 02:32
@rkuester rkuester requested a review from suleshahid December 7, 2024 02:33
inline size_t GetNextTableIndexWidth2(const size_t current_offset);
inline size_t GetNextTableIndexWidth1(const size_t current_offset);

protected:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suleshahid The Xtensa subclass needs access.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right.

Copy link
Contributor

mergify bot commented Dec 10, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #2996 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: 19 of 20 required status checks are expected.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify mergify bot merged commit d59136a into tensorflow:main Dec 10, 2024
98 of 99 checks passed
@rkuester rkuester deleted the feat-compression branch December 10, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants