Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate StridedSlice Init and Prepare #2203

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

rascani
Copy link
Contributor

@rascani rascani commented Aug 31, 2023

The Init and Prepare functions were entirely common between the reference kernel and the Xtensa optimized kernel. This PR relocates the common functions to a strided_slice_common.cc file to be used on both platforms. This reduces the reference kernel and xtena kernel files to just the Eval function.

BUG=cleanup

The Init and Prepare functions were entirely common between the
reference kernel and the Xtensa optimized kernel. This PR relocates the
common functions to a strided_slice_common.cc file to be used on both
platforms. This reduces the reference kernel and xtena kernel files to
just the Eval function.

BUG=cleanup
@rascani rascani requested a review from a team as a code owner August 31, 2023 21:43
@rascani rascani added the ci:run label Aug 31, 2023
@TFLM-bot TFLM-bot removed the ci:run label Aug 31, 2023
@rascani
Copy link
Contributor Author

rascani commented Aug 31, 2023

Closing in favor of #2202

@rascani rascani closed this Aug 31, 2023
@rascani rascani reopened this Aug 31, 2023
@rascani
Copy link
Contributor Author

rascani commented Aug 31, 2023

Whoops, wrong PR.

@mergify mergify bot merged commit 1dfe2bc into tensorflow:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants