Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

fix encoding error when piping stdout to file #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhuoqyin
Copy link

@zhuoqyin zhuoqyin commented Aug 14, 2017

The new code changes would raise UnicodeDecodeError on some terminals when you redirect the output to file.

See this stackoverflow for detailed explanation.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@zhuoqyin
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@oahziur
Copy link
Contributor

oahziur commented Aug 16, 2017

Hi @zhuoqyin ,

I think this bug has been fixed in the master branch, can you check if you still get the UnicodeDecodeError in your terminal with the current head? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants